Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Supported models #2386

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

Vaibhavs10
Copy link
Member

@Vaibhavs10 Vaibhavs10 commented Aug 9, 2024

What does this PR do?

Adds links to collections for Llama and Gemma 2 models and updates the Mistral model placeholder to their latest Apache 2.0 licensed model.

In addition to this it adds minor changes to the update_doc.py's supported models template.

Updates the README to add mention of Messages API and quantization methods.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Narsil
Narsil previously approved these changes Aug 9, 2024
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vaibhavs10 Vaibhavs10 marked this pull request as draft August 9, 2024 12:11
@Vaibhavs10 Vaibhavs10 marked this pull request as ready for review August 9, 2024 12:51
@Narsil Narsil merged commit b2b9c42 into huggingface:main Aug 9, 2024
4 of 8 checks passed
@Vaibhavs10 Vaibhavs10 deleted the vb/followup-doc-fixes branch August 9, 2024 13:01
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* Minor doc fixes

* up.

* Other minor updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants