Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using an enum for flash backens (paged/flashdecoding/flashinfer) #2385

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Aug 9, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil requested a review from danieldk August 9, 2024 10:31
danieldk
danieldk previously approved these changes Aug 9, 2024
@danieldk
Copy link
Member

danieldk commented Aug 9, 2024

Clippy is still unhappy.

@danieldk danieldk merged commit 7a48a84 into main Aug 9, 2024
9 checks passed
@danieldk danieldk deleted the enum_flash_backends branch August 9, 2024 14:41
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
…gingface#2385)

* Using an enum for flash backens (paged/flashdecoding/flashinfer)

* Early exit on server too.

* Clippy.

* Fix clippy and fmt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants