fix: reject grammars without properties #2309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adds a new check to grammar validation that ensures that the grammar contains
properties
For a grammar to be valid it needs to 1. be a valid
JSON Schema
, and 2. haveproperties
that are used to constrain the output.This PR is related to
pr: #2282
issue: #2280
req/res example
The following request would crash TGI due to outlines failing to parse the grammar, now an error is returned because
value
does not includeproperties
now returns