Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model load fix for qwen2 0.5b and 1.5b #2303

Conversation

matvey-kolbasov-hs
Copy link

Fix for Qwen2 model loading

This PR fixes an issue with loading for models Qwen2 0.5B and Qwen2 1.5B. These models use tied embeddings so they require corresponding aliases for layer names.

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@danieldk danieldk self-assigned this Jul 25, 2024
Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this and providing a PR!

Since the model configuration states whether the embeddings are tied or not, I think it's nicer to rely on the configuration rather than aliases.

See #2313.

@danieldk
Copy link
Member

Fixed by #2313. Thanks again for pointing out this issue and providing a fix!

@danieldk danieldk closed this Jul 26, 2024
@danieldk danieldk removed their assignment Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants