Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Llama 3 rotary embeddings #2286

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

danieldk
Copy link
Member

What does this PR do?

Add support for Llama 3 rotary embeddings.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Narsil
Narsil previously approved these changes Jul 23, 2024
@danieldk danieldk merged commit 4ab4173 into main Jul 23, 2024
5 of 6 checks passed
@danieldk danieldk deleted the feature/llama3-rotary branch July 23, 2024 15:18
ErikKaum pushed a commit that referenced this pull request Jul 25, 2024
* Add support for Llama 3 rotary embeddings

* Update transformers to 4.43
ErikKaum pushed a commit that referenced this pull request Jul 26, 2024
* Add support for Llama 3 rotary embeddings

* Update transformers to 4.43
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* Add support for Llama 3 rotary embeddings

* Update transformers to 4.43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants