Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove bitsandbytes installation when running cpu-only install #2216

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Hugoch
Copy link
Member

@Hugoch Hugoch commented Jul 11, 2024

What does this PR do?

It removes the installation of bitsandbytes when doing a make install-cpu. The package is not needed on non-CUDA arch and fails to install on Darwin architecture as 0.43.0 removed support for the MacOS arch.

Fixes #2214

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

@Hugoch Hugoch marked this pull request as ready for review July 12, 2024 08:20
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for updating.

longer term I think we'll want to rename requirements_cuda in install-server since its used for cpu installs. However those changes are outside of the scope of this PR and we can revisit them soon

@Hugoch Hugoch merged commit 0ad7f6f into main Jul 15, 2024
9 checks passed
@Hugoch Hugoch deleted the bug/2214-fix-bits-and-bytes-macos branch July 15, 2024 13:34
ErikKaum pushed a commit that referenced this pull request Jul 25, 2024
…2216)

Remove bitsandbytes installation when running cpu-only install
ErikKaum pushed a commit that referenced this pull request Jul 26, 2024
…2216)

Remove bitsandbytes installation when running cpu-only install
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
…uggingface#2216)

Remove bitsandbytes installation when running cpu-only install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitsandbytes==0.43.0 not supported on MacOS
2 participants