Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HF_TOKEN environment variable #2066

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 13, 2024

Related to slack thread (internal).

This PR replaces HUGGING_FACE_HUB_TOKEN by HF_TOKEN to be more consistent with the HF ecosystem (in a backward-compatible way). HUGGING_FACE_HUB_TOKEN is not documented anymore.

Note: I did not change secrets.HUGGING_FACE_HUB_TOKEN in Github secrets but it would make sense to switch it as well. Requires admin privilege on the repo + 3 minor updates in .yaml files.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Narsil
Narsil previously approved these changes Jun 24, 2024
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil force-pushed the support-hf-token-env-variable branch from 626f339 to 16f619c Compare June 24, 2024 17:35
@Narsil Narsil merged commit 3447c72 into main Jun 25, 2024
5 of 7 checks passed
@Narsil Narsil deleted the support-hf-token-env-variable branch June 25, 2024 07:23
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* Support HF_TOKEN environement variable

* Load test.

---------

Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants