Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor config chat template #1954

Merged
merged 2 commits into from
May 27, 2024
Merged

Processor config chat template #1954

merged 2 commits into from
May 27, 2024

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented May 27, 2024

This PR loads the processor_config similar to the tokenizer_config and uses the processor_config's chat_template if the tokenizer_config does not include one. These changes enable chat with idefics2

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 0732b9d into main May 27, 2024
8 checks passed
@Narsil Narsil deleted the processor-config-chat-template branch May 27, 2024 14:03
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
This PR loads the `processor_config` similar to the `tokenizer_config`
and uses the processor_config's chat_template if the tokenizer_config
does not include one. These changes enable chat with idefics2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants