Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use path inside of speculator config #1935

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented May 22, 2024

This PR access the path on the speculator similar to MLPSpeculatorHead.load and MedusaHeadV1.load

these changes resolves this error locally when loading a MedusaHeadV2

TypeError: expected str, bytes or os.PathLike object, not dict

@Narsil Narsil merged commit efb73fc into main May 22, 2024
6 of 8 checks passed
@Narsil Narsil deleted the adjust-speculator-path branch May 22, 2024 18:46
@Narsil
Copy link
Collaborator

Narsil commented May 22, 2024

Lgtm

yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Jul 17, 2024
This PR access the path on the speculator similar to
`MLPSpeculatorHead.load` and `MedusaHeadV1.load`

these changes resolves this error locally when loading a `MedusaHeadV2`
```
TypeError: expected str, bytes or os.PathLike object, not dict
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants