Handle Jinja error messages #292
Merged
+36
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
reviewed
Nov 24, 2025
DePasqualeOrg
force-pushed
the
handle-jinja-error-messages
branch
from
3b0fb2f to
ca0e333
Compare
mattt
approved these changes
Nov 24, 2025
Collaborator
|
Thank you for your contributions to this package and swift-jinja. I agree with your changes here. @pcuenca Does this look good to you? Or do you have any suggestions for how to surface these errors differently? |
Member
|
We could potentially use a different error, but this works for me if it works for @DePasqualeOrg! |
pcuenca
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to surface error messages from Jinja so that consuming apps can show them in the UI. Currently they're thrown as a
JinjaError, which means consuming apps would have to check for that error type in order to show the error message. Here I'm checking forJinjaErrorinapplyChatTemplateand wrapping the error message inTokenizerError.chatTemplate. I'm not sure if this is the best solution, but it does expose the error message from Jinja in my app.See huggingface/swift-jinja#39