Tokenizers don't need config.json #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'll add a test later. |
FL33TW00D
approved these changes
Sep 24, 2025
pcuenca
force-pushed
the
tokenizers-dont-need-model-config
branch
from
3d78220 to
46cd5ab
Compare
Member
Author
|
I tried to skip downloads of model configurations, but I realized there are still edge cases for old tokenizers where the tokenizer class is retrieved from the model config. We need to look into this better. This is another fallback mechanism in addition to #251. |
Merged
Member
Author
|
Merging this for now, will improve the fallback cases later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can do for now, but in fact, we should not even attempt to download
config.jsonwhen loading a tokenizer.