Conditionally import CoreML and Accelerate frameworks #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! |
Member
|
Can we potentially restrict |
Collaborator
Author
I think that's possible, but I don't think I've ever seen that in the wild. I'm familiar with how errors are communicated when APIs aren't available due to conditional compilation. If we wanted to make that experience nicer, we could add an |
Member
|
Ok, no need to spend more time on it then. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #176
The
Hubmodule and other products of theswift-transformerspackage could theoretically be used on Linux, Window, Wasm, or other platforms. As a prerequisite, this PR conditionalizes imports ofCoreMLandAccelerate, which are specific to macOS and iOS.