Skip to content

Conversation

@mattt
Copy link
Collaborator

@mattt mattt commented Aug 21, 2025

In working on #168, I found that my editor's configured format-on-save behavior was causing churn and CI failures (sorry about that!)

This PR adds a .vscode directory to configure VSCode (plus derivatives like Cursor) to do the following:

These settings should reduce the number of failed CI jobs due to formatting issues, and provide a nice baseline experience for developers using VSCode, et al.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me! Feel free to get it out of Draft mode whenever you are ready.

Also cc @FL33TW00D.

@pcuenca pcuenca requested a review from FL33TW00D August 21, 2025 14:36
@pcuenca
Copy link
Member

pcuenca commented Aug 21, 2025

Forgot to mention that we are pinning swiftformat 0.57.2 in the CI because we noticed rules divergence 🤦.

@FL33TW00D
Copy link
Contributor

LGTM!

@pcuenca
Copy link
Member

pcuenca commented Aug 22, 2025

Feel free to merge when you're ready @mattt!

@mattt mattt marked this pull request as ready for review August 23, 2025 08:55
@mattt
Copy link
Collaborator Author

mattt commented Aug 23, 2025

Thanks for taking a look! Merging this now.

@mattt mattt merged commit ae0ead8 into main Aug 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants