Skip to content

Conversation

belambert
Copy link

I was working through Unit 1 Exercise 1 of the smol course and noticed that the code in the notebook got a little out of sync with what's in the Markdown/HTML. I attempted to copy it over and ended up with this. I haven't looked closely at the other units and exercises yet.

I don't think I've PR'ed any Huggingface repos before, so let me know if there's anything I should do differently with PRs 😄

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 22:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes code examples in the Unit 1 Exercise 1 documentation with the corresponding notebook implementation. The changes add system messages with /no_think and /think directives to conversation examples and update the reasoning capabilities testing section.

  • Added system messages with /no_think and /think directives to chat template examples
  • Updated reasoning test code to iterate through different thinking prompts
  • Fixed minor formatting inconsistencies in function parameters and code structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant