Skip to content

Fix num_classes update in reset_classifier and RDNet forward head call #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ def test_model_default_cfgs(model_name, batch_size):

# test forward after deleting the classifier, output should be poooled, size(-1) == model.num_features
model.reset_classifier(0)
assert model.num_classes == 0, f'Expected num_classes to be 0 after reset_classifier(0), but got {model.num_classes}'
model.to(torch_device)
outputs = model.forward(input_tensor)
assert len(outputs.shape) == 2
Expand Down Expand Up @@ -339,6 +340,7 @@ def test_model_default_cfgs_non_std(model_name, batch_size):

# test forward after deleting the classifier, output should be poooled, size(-1) == model.num_features
model.reset_classifier(0)
assert model.num_classes == 0, f'Expected num_classes to be 0 after reset_classifier(0), but got {model.num_classes}'
model.to(torch_device)
outputs = model.forward(input_tensor)
if isinstance(outputs, (tuple, list)):
Expand Down
1 change: 1 addition & 0 deletions timm/models/davit.py
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, global_pool)

def forward_features(self, x):
Expand Down
1 change: 1 addition & 0 deletions timm/models/focalnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, pool_type=global_pool)

def forward_features(self, x):
Expand Down
1 change: 1 addition & 0 deletions timm/models/metaformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
if global_pool is not None:
self.head.global_pool = SelectAdaptivePool2d(pool_type=global_pool)
self.head.flatten = nn.Flatten(1) if global_pool else nn.Identity()
Expand Down
1 change: 1 addition & 0 deletions timm/models/nextvit.py
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, pool_type=global_pool)

def forward_features(self, x):
Expand Down
1 change: 1 addition & 0 deletions timm/models/nfnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, global_pool)

def forward_features(self, x):
Expand Down
2 changes: 1 addition & 1 deletion timm/models/pvt_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
if global_pool is not None:
assert global_pool in ('avg', '')
self.global_pool = global_pool
self.head = nn.Linear(self.embed_dim, num_classes) if num_classes > 0 else nn.Identity()
self.head = nn.Linear(self.num_features, num_classes) if num_classes > 0 else nn.Identity()

def forward_features(self, x):
x = self.patch_embed(x)
Expand Down
3 changes: 2 additions & 1 deletion timm/models/rdnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, global_pool)

def forward_features(self, x):
Expand All @@ -361,7 +362,7 @@ def forward_head(self, x, pre_logits: bool = False):

def forward(self, x):
x = self.forward_features(x)
x = self.head(x)
x = self.forward_head(x)
return x

@torch.jit.ignore
Expand Down
1 change: 1 addition & 0 deletions timm/models/regnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, pool_type=global_pool)

def forward_intermediates(
Expand Down
1 change: 1 addition & 0 deletions timm/models/tresnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, pool_type=global_pool)

def forward_features(self, x):
Expand Down
1 change: 1 addition & 0 deletions timm/models/vision_transformer_sam.py
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,7 @@ def get_classifier(self) -> nn.Module:
return self.head

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, global_pool)

def forward_intermediates(
Expand Down
1 change: 1 addition & 0 deletions timm/models/xception_aligned.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def get_classifier(self) -> nn.Module:
return self.head.fc

def reset_classifier(self, num_classes: int, global_pool: Optional[str] = None):
self.num_classes = num_classes
self.head.reset(num_classes, pool_type=global_pool)

def forward_features(self, x):
Expand Down
Loading