Update tokenizer parameter in sfttrainer across multiple examples - #2664
Merged
Conversation
…stances across multiple examples
Contributor
Author
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
reviewed
Jul 22, 2025
githubnemo
left a comment
githubnemo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick fix :)
Generally looks good but I think instances of Trainer/Seq2SeqTrainer need updating as well, I found these but there may be more:
docs/source/quicktour.mddocs/source/task_guides/lora_based_methods.mdexamples/conditional_generation/peft_prompt_tuning_seq2seq_with_generate.ipynb
…stances across documentation and examples
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
Collaborator
|
@gapsong check |
- Updated the Trainer initialization in corda_finetuning.py to use processing_class instead of tokenizer. - Changed the execution_count to null in image_classification_peft_lora.ipynb. - Modified the tokenizer parameter to processing_class in image_classification_peft_lora.ipynb. - Adjusted the tokenizer parameter to processing_class in peft_bnb_whisper_large_v2_training.ipynb. - Updated the README.md in lorafa_finetune to reflect the change from tokenizer to processing_class in Trainer initialization.
Contributor
Author
|
Ok found some more. The rest are from GPTQconfigs and datasetcollators. |
… notebook examples
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Jul 28, 2025
…ggingface#2664) * REFAC Update tokenizer parameter to processing_class in SFTTrainer instances across multiple examples * REFAC Replace tokenizer parameter with processing_class in Trainer instances across documentation and examples * Refactor tokenizer parameter to processing_class in various examples - Updated the Trainer initialization in corda_finetuning.py to use processing_class instead of tokenizer. - Changed the execution_count to null in image_classification_peft_lora.ipynb. - Modified the tokenizer parameter to processing_class in image_classification_peft_lora.ipynb. - Adjusted the tokenizer parameter to processing_class in peft_bnb_whisper_large_v2_training.ipynb. - Updated the README.md in lorafa_finetune to reflect the change from tokenizer to processing_class in Trainer initialization. * REFAC Update tokenizer parameter to processing_class in Seq2SeqTrainer instantiation * REFAC Replace tokenizer parameter with processing_class in README and notebook examples
iambogeumkim
pushed a commit
to iambogeumkim/peft
that referenced
this pull request
Jun 21, 2026
…ggingface#2664) * REFAC Update tokenizer parameter to processing_class in SFTTrainer instances across multiple examples * REFAC Replace tokenizer parameter with processing_class in Trainer instances across documentation and examples * Refactor tokenizer parameter to processing_class in various examples - Updated the Trainer initialization in corda_finetuning.py to use processing_class instead of tokenizer. - Changed the execution_count to null in image_classification_peft_lora.ipynb. - Modified the tokenizer parameter to processing_class in image_classification_peft_lora.ipynb. - Adjusted the tokenizer parameter to processing_class in peft_bnb_whisper_large_v2_training.ipynb. - Updated the README.md in lorafa_finetune to reflect the change from tokenizer to processing_class in Trainer initialization. * REFAC Update tokenizer parameter to processing_class in Seq2SeqTrainer instantiation * REFAC Replace tokenizer parameter with processing_class in README and notebook examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tokenizer parameter in sfttrainer across multiple examples
#2663