Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with doc build sometimes failing silently in GH workflows #960

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Apr 7, 2023

What does this PR do?

This PR aims at avoiding silent errors when building the documentation in a Github workflow (see here for an example).

It seems that

defaults:
  run:
    shell: bash -l {0}

that is used in the main documentation build workflow makes some errors silent. Removing it since it is not necessary for building the doc.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2023

The documentation is not available anymore as the PR was closed or merged.

@regisss regisss marked this pull request as ready for review April 8, 2023 22:13
@regisss regisss requested a review from fxmarty April 8, 2023 22:13
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 97069a0 into main Apr 11, 2023
@regisss regisss deleted the fix_silent_errors_doc_build branch April 11, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants