Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FlaubertOnnxConfig #669

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix FlaubertOnnxConfig #669

merged 1 commit into from
Jan 5, 2023

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Flaubert requires token_type_ids just like BERT, so FlaubertOnnxConfig inherints from BertOnnxConfig instead of DistilBertOnnxConfig to fix that.

Fixes #667

@michaelbenayoun
Make FlaubertOnnxConfig inherint from BertOnnxConfig instead of Disti…
1b9978f 
…lbertOnnxConfig since it requires token_type_ids
@michaelbenayoun michaelbenayoun mentioned this pull request Jan 4, 2023
Closed
4 tasks
@fxmarty fxmarty mentioned this pull request Jan 4, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 4, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@michaelbenayoun michaelbenayoun merged commit 649e9bd into huggingface:main Jan 5, 2023
@michaelbenayoun michaelbenayoun deleted the flaubert_onxn_export_fix branch January 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A weird input in onnx graph from ORTModel pretrained FlauBERT
2 participants
@michaelbenayoun @HuggingFaceDocBuilderDev