Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set onnx max dependecy #1037

Merged
merged 2 commits into from
May 7, 2023
Merged

Set onnx max dependecy #1037

merged 2 commits into from
May 7, 2023

Conversation

echarlaix
Copy link
Collaborator

Set onnx max dependency to make it compatible with ONNX Runtime inference

"onnxruntime-gpu>=1.9.0",
"datasets>=1.2.1",
"evaluate",
"protobuf>=3.20.1",
],
"exporters": ["onnx", "onnxruntime", "timm"],
"exporters-gpu": ["onnx", "onnxruntime-gpu", "timm"],
"exporters": ["onnx<1.14.0", "onnxruntime", "timm"],
Copy link
Collaborator Author

@echarlaix echarlaix May 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it compatible in case it's needed for ONNX Runtime (cc @regisss)

@echarlaix echarlaix requested a review from regisss May 7, 2023 14:09
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Weird that a few tests failed because. It seems PIP constraint solver had an issue in those tests.

@echarlaix echarlaix merged commit 971ab38 into main May 7, 2023
@echarlaix echarlaix deleted the add-dep branch May 7, 2023 20:35
echarlaix added a commit that referenced this pull request May 7, 2023
* Set onnx requirement

* Add TF < 2.12 in the test_onnx workflow

---------

Co-authored-by: regisss <regis@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants