-
Notifications
You must be signed in to change notification settings - Fork 173
[OpenVINO] Support Arcee Trinity (aka Afmoe) models collection #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
nikita-savelyevv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I observe that the export and inference takes a very long time. Could you please add the same warning as the one we've added recently for Zamba2?
Another issue is that weight quantization is very slow because there are 20k weight constants to quantize. I believe we had a similar issue for Qwen/Qwen3-30B-A3B until MoE merging was added to OpenVINO. Do you know, is it expected for the same approach to work for this model?
Also, please take a look at the failing tests.
| library_name="transformers", | ||
| ) | ||
| class AfmoeOpenVINOConfig(LlamaOpenVINOConfig): | ||
| MIN_TRANSFORMERS_VERSION = "4.55.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this architecture is already supported in transformers https://github.com/huggingface/transformers/blob/v5.0.0rc0/src/transformers/models/afmoe/modeling_afmoe.py I think we shouldn't add support to the remote code version. We would also need to add support to the latest transformers version (will open a PR for this soon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @echarlaix, we have urgent request from customer for this model. optimum-intel doesn't support v5 transformers yet. I propose to proceed with remote-code support for v4 now.
|
thanks for the addition @rkazants |
What does this PR do?
Note: Currently, the model is a remote-code model for transformers "4.x.y" version.
Example of conversion cmd-line for
arcee-ai/Trinity-Nano-Preview:optimum-cli export openvino -m arcee-ai/Trinity-Nano-Preview Trinity-Nano-Preview --trust-remote-codeExample of inference for
arcee-ai/Trinity-Nano-Previewusing OpenVINO backend:Before submitting