Skip to content

Comments

[OpenVINO] Update SAM low precision references#1499

Merged
nikita-savelyevv merged 3 commits intomainfrom
ns/update-sam-references
Oct 30, 2025
Merged

[OpenVINO] Update SAM low precision references#1499
nikita-savelyevv merged 3 commits intomainfrom
ns/update-sam-references

Conversation

@nikita-savelyevv
Copy link
Contributor

What does this PR do?

Update int4/int8 reference numbers after an ignored pattern was added for positional embedding layer openvinotoolkit/nncf#3700 .

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@nikita-savelyevv nikita-savelyevv added the openvino-nightly Runs OpenVINO nightly and NNCF develop tests label Oct 29, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Nikita Savelyev added 2 commits October 29, 2025 13:01
@nikita-savelyevv
Copy link
Contributor Author

Merging as failing tests are unrelated.

@nikita-savelyevv nikita-savelyevv merged commit 7098e94 into main Oct 30, 2025
47 of 53 checks passed
@nikita-savelyevv nikita-savelyevv deleted the ns/update-sam-references branch October 30, 2025 09:00
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nikita-savelyevv !

Not related to this PR but I'm seeing a new error for export in fp16 (for sam and gpt2 models) with openvino-nightly which previously wasn't present, any chances you have an idea on what could be the cause ?

RuntimeError: Check 'node->constant_fold(outputs, node->input_values())' failed at src/core/src/xml_util/xml_serialize_util.cpp:59

@nikita-savelyevv
Copy link
Contributor Author

LGTM, thanks @nikita-savelyevv !

Not related to this PR but I'm seeing a new error for export in fp16 (for sam and gpt2 models) with openvino-nightly which previously wasn't present, any chances you have an idea on what could be the cause ?

RuntimeError: Check 'node->constant_fold(outputs, node->input_values())' failed at src/core/src/xml_util/xml_serialize_util.cpp:59

Thanks @echarlaix! I don't have this understanding yet, we will investigate this internally.

cc @rkazants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openvino-nightly Runs OpenVINO nightly and NNCF develop tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants