Readme Update for FSDP #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Readme to indicate flash attention support for LLama2 70b with FSDP. This improves performance as well as memory footprint
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@regisss please review this readme change and merge this change when we transition to Synapse 1.16.0. We have tested this change on G2 with Synapse 1.16.0, this gives a small boost in performance. |
|
Does this work with 1.15? |
|
@regisss This is for 1.16; it does not work properly for 1.15 |
libinta
added
synapse 1.16_dependency
Fused SDPA leads to a small drop in the perf for 7b model; so updating the test case. For 70b we see a perf improvement.
hsubramony
added a commit
that referenced
this pull request
May 29, 2024
regisss
approved these changes
May 30, 2024
hsubramony
added a commit
that referenced
this pull request
May 31, 2024
|
@regisss Can we merge this now? |
imangohari1
pushed a commit
to imangohari1/optimum-habana
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Readme to indicate flash attention support for LLama2 70b with FSDP. This improves performance as well as memory footprint
What does this PR do?
Fixes # (issue)
Before submitting