Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade optimum-habana diffusers dependency from 0.26.3 to 0.29.2 #1150

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

dsocek
Copy link
Contributor

@dsocek dsocek commented Jul 22, 2024

Upgrade optimum-habana diffusers from 0.26.3 to 0.29.2

  • Updated optimum-habana diffusers to 0.29.2 in setup.py
  • Fixed SVD (GaudiStableVideoDiffusionPipeline) to handle updated API in 0.29.2 for tensor2vid and instead use video_processor.postprocess_video
  • Fixed GaudiStableDiffusionControlNetPipeline to handle updated check_inputs API in 0.29.2
  • Fixed tests/test_diffusers.py to use to(dtype=...) instead of to(torch_dtype=...) which is deprecated starting diffusers 0.27.0 (See here)
  • Clean-up SVD to remove all inheritable functions
  • Updated warmup logic in SVD
  • Updated documentation example with command line for SVD that yields improved performance

Tests

Ran tests on G2:

export RUN_SLOW=true
export GAUDI2_CI=1
make test_installs
python -m pytest tests/test_diffusers.py

Diffusers test results before diffusers upgrade:

17 failed, 106 passed, 13 skipped, 65 warnings in 2304.15s (0:38:24)

Diffusers test results after diffusers upgrade:

16 failed, 107 passed, 13 skipped, 316 warnings in 2157.94s (0:35:57)

Note: Update is needed for supporting enabling newest pipelines such as Stable Diffusion 3, etc.

@dsocek dsocek requested a review from regisss as a code owner July 22, 2024 21:16
@dsocek dsocek force-pushed the diffusers-0.29.2-upgrade branch from 27ff798 to da20428 Compare July 23, 2024 23:24
@dsocek dsocek mentioned this pull request Jul 24, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dsocek dsocek force-pushed the diffusers-0.29.2-upgrade branch 4 times, most recently from 4ab70de to 9d115fd Compare August 3, 2024 15:33
dsocek and others added 2 commits August 3, 2024 15:38
* Update optimum-habana diffusers to 0.29.2 in setup.py
* Fix SVD (GaudiStableVideoDiffusionPipeline) to handle updated API for tensor2vid
* Fix GaudiStableDiffusionControlNetPipeline to handle updated check_inputs API
* Fix tests/test_diffusers.py to use to(dtype=...) instead of to(torch_dtype=...) which is now deprecated
* Clean-up SVD to remove all inheritable functions
* Updated warmup logic in SVD
* Updated documentation example with command line for SVD that yields improved performace

Signed-off-by: Daniel Socek <daniel.socek@intel.com>
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I removed the datasets < 2.20.0 line in setup.py. You may have got issues with datasets that needs trust_remote_code=True.

@regisss regisss merged commit 9e4a67f into huggingface:main Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants