Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FusedSDPA for Mpt #1101

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Enable FusedSDPA for Mpt #1101

merged 3 commits into from
Aug 16, 2024

Conversation

Jianhong-Zhang
Copy link
Contributor

@Jianhong-Zhang Jianhong-Zhang commented Jun 26, 2024

Enable FusedSDPA for Mpt

Signed-off-by: Jianhong Zhang jianhong.zhang@intel.com
co-authored-by: Ling, Jing1 jing1.ling@intel.com

@Jianhong-Zhang Jianhong-Zhang force-pushed the mpt2 branch 2 times, most recently from 2dc4a4a to 3afa292 Compare July 24, 2024 23:09
@Jianhong-Zhang Jianhong-Zhang marked this pull request as ready for review July 24, 2024 23:09
@Jianhong-Zhang Jianhong-Zhang requested a review from mandy-li as a code owner July 24, 2024 23:09
@mandy-li mandy-li requested review from schoi-habana and regisss July 24, 2024 23:33
@Jianhong-Zhang Jianhong-Zhang marked this pull request as draft July 25, 2024 01:55
@Jianhong-Zhang Jianhong-Zhang force-pushed the mpt2 branch 2 times, most recently from 62e67ee to 523bc99 Compare July 25, 2024 04:25
@Jianhong-Zhang Jianhong-Zhang marked this pull request as ready for review July 26, 2024 03:44
@Jianhong-Zhang Jianhong-Zhang marked this pull request as draft July 26, 2024 04:50
@Jianhong-Zhang Jianhong-Zhang marked this pull request as ready for review July 31, 2024 19:28
@Jianhong-Zhang
Copy link
Contributor Author

No more long graph compilation issue observed with newer docker version for FusedSDPA.

docker_version: Docker version : 1.17.0
pt_version: PyTorch version : 2.3.1
build_version: Build version :488

Signed-off-by: Jianhong Zhang <jianhong.zhang@intel.com>
co-authored-by: Ling, Jing1 <jing1.ling@intel.com>
Copy link
Collaborator

@schoi-habana schoi-habana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atakaha
Copy link
Contributor

atakaha commented Aug 7, 2024

Could you provide command line and some data with/without FusedSDPA?

@Jianhong-Zhang
Copy link
Contributor Author

Could you provide command line and some data with/without FusedSDPA?

Details refer to https://habana.atlassian.net/browse/GS-329
Any other question, we can discuss offline

@mandy-li mandy-li added the run-test Run CI for PRs from external contributors label Aug 7, 2024
@mandy-li
Copy link
Collaborator

mandy-li commented Aug 7, 2024

@regisss , please review and merge if ok for you. thanks

@Jianhong-Zhang
Copy link
Contributor Author

@regisss, can you please review the pr? thanks

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit ad20e0c into huggingface:main Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants