-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sasarkar/fusedrope inp bf16 #1026
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked the accuracy of the trained models with this change? RoPE is quite sensitive to the data type that is used to compute it.
for a small text gen expt:
Got exactly same outputs Training:
with branch
So looks same with the branch. There are also other internal tests and we havent seen accuracy issues |
What does this PR do?
pulling in this: HabanaAI@1d44433
Fixes # (issue)
Before submitting