Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackers revamp #178

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Trackers revamp #178

merged 4 commits into from
Apr 10, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

  • Standardizing the latency trackers and making them only track, the timing is handled by a separate class Timer.
  • Making the memory tracker more robust when used with launch, by monitoring the main benchmark process (so no need to aggregate VRAM over multiple processes) and supporting both per process and global VRAM tracking at the same time.

@IlyasMoutawwakil
Copy link
Member Author

@franchukpetro I know you've been using VRAM measurements by setting PROCESS_SPECIFIC_VRAM.
This PR removes that environment variable in favor of reporting both (memory.max_global_vram and memory.max_process_vram), hope this makes VRAM benchmarking easier 🤗

@IlyasMoutawwakil IlyasMoutawwakil merged commit 9459906 into main Apr 10, 2024
19 checks passed
@franchukpetro
Copy link

Makes sense, thanks a lot for letting me know, @IlyasMoutawwakil!

@IlyasMoutawwakil IlyasMoutawwakil deleted the trackers-revamp branch May 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants