Skip to content

Newer openai and loosened httpx #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Newer openai and loosened httpx #758

wants to merge 2 commits into from

Conversation

jamesbraza
Copy link

@jamesbraza jamesbraza commented May 21, 2025 •
edited
Loading

#648 locked httpx and openai for some AttributeError. Newer openai should work

Resolves #747

NathanHB
NathanHB reviewed May 21, 2025
View reviewed changes
Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! you did not seem to loosen the httpx dep ?

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jamesbraza jamesbraza force-pushed the looser-httpx-openai branch from bc1abd6 to c19ca14 Compare May 21, 2025 17:07
@jamesbraza
Copy link
Author

Thanks ! you did not seem to loosen the httpx dep ?

HA thanks for pointing that out. This type of mistake annoys me in the open source repos I work in, and now I made the same mistake!

Anyways, resolved it just now, PR is ready for review

@jamesbraza jamesbraza requested a review from NathanHB May 21, 2025 17:08
@jamesbraza
Copy link
Author

Running uv lock --upgrade on this branch:

> uv lock --upgrade
Resolved 262 packages in 289ms
Updated httpx v0.27.2 -> v0.28.1
Updated litellm v1.53.3 -> v1.70.2
Updated openai v1.55.2 -> v1.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanHB NathanHB Awaiting requested review from NathanHB

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FT] allow httpx>0.27
3 participants
@jamesbraza @HuggingFaceDocBuilderDev @NathanHB