-
Notifications
You must be signed in to change notification settings - Fork 256
Added Flores #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Flores #717
Conversation
…t to have a custom enum with one key several values
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
||
# ------------------------------- Translation Tasks ------------------------------- # | ||
flores_200_languages = [ | ||
"ace_Arab", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different scripts won't really work, because of how template is constructed :/.
We must choose one of the scripts and comment out the rest....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be more interesting to add the script to the Language enum and use it in the template functions I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a look on Mon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be the "correct" solution, yes. If you have time it would be great, but we are fine with just having one default script as of right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then merging the simplest and I'll open an issue for adding script in the enum
* adding relevant languages + sorting everyone * added chrf++ * updated language list to rm redundancies, renamed task to follow usual pattern * fix adapter plus manage languages simply - in the future we might want to have a custom enum with one key several values
cc @loubnabnl and @hynky1999 :)