Skip to content

Added Flores #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 19, 2025
Merged

Added Flores #717

merged 9 commits into from
May 19, 2025

Conversation

clefourrier
Copy link
Member

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


# ------------------------------- Translation Tasks ------------------------------- #
flores_200_languages = [
"ace_Arab",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different scripts won't really work, because of how template is constructed :/.
We must choose one of the scripts and comment out the rest....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be more interesting to add the script to the Language enum and use it in the template functions I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a look on Mon

Copy link
Collaborator

@hynky1999 hynky1999 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be the "correct" solution, yes. If you have time it would be great, but we are fine with just having one default script as of right now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then merging the simplest and I'll open an issue for adding script in the enum

@NathanHB NathanHB linked an issue May 15, 2025 that may be closed by this pull request
@clefourrier clefourrier merged commit 63be4b0 into main May 19, 2025
5 checks passed
hynky1999 pushed a commit that referenced this pull request May 22, 2025
* adding relevant languages + sorting everyone
* added chrf++
* updated language list to rm redundancies, renamed task to follow usual pattern
* fix adapter plus manage languages simply - in the future we might want to have a custom enum with one key several values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EVAL] adds FLORES
4 participants