-
Notifications
You must be signed in to change notification settings - Fork 256
Adds multimodal support and MMMU pro #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need working will mainly be here, first is to have the greedy untill function working
# TODO: What is the best option to pass images to the requests? | ||
# dirty hack for now | ||
for reqs in requests.values(): | ||
for req in reqs: | ||
req.specific = formatted_doc.specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the best option to pass images to the requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now it would be using specifics
but we could also add an images
field to the request that default to None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NathanHB, thanks for reviewing the PR. As we discussed internally, the only thing left is the tests, and the rest can be merged in the current state.
I also plan to conduct more experiments to evaluate VLM models after my vacation, and maybe, we will already have some user feedback to improve the evaluation.
I also left some comments, feel free to resolve them (if needed) while adding tests 🤗 Thanks!
hey @qubvel Taking care of adding tests and removing unneded stuff, thank you so much for the help in adding this feature :) |
``` uv run lighteval accelerate "model_name=HuggingFaceTB/SmolVLM-Instruct" "lighteval|mmmu_pro|0|0" --use-chat-template --vision-model ``` --------- Co-authored-by: qubvel <qubvel@gmail.com>
Aims to add multimodal support for transformers model by creating the
VLMTransformersModel
.Adds the MMMU task
modify the prompt manager to support multimodal input (images for now)
adds a
lighteval accelerate vlm
cli entry for creating the right config and using theVLMTransformersModel
tests failing is because of shortcut it's normal
To test / use: