Open
Conversation
danieldk
reviewed
Feb 12, 2026
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
Member
There was a problem hiding this comment.
Thanks for submitting a pull request!
I am not sure if we want this, since it suggests that the kernels themselves are under this license. Some tools might automatically extract the top-level license and then assume that the code is under it.
For kernels we have the new license build.toml option. I think the build.toml of each kernel should just be under the same license as the individual kernel.
Collaborator
There was a problem hiding this comment.
Agreed, each kernel should probably be handled independently I think
MekkCyber
reviewed
Feb 12, 2026
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
Collaborator
There was a problem hiding this comment.
Agreed, each kernel should probably be handled independently I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/huggingface/kernels already uses Apache 2.0 so I assume this is an appropriate choice?