Return early in is_jsonable
if circular reference
#3348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an object has a circular reference (e.g. a dictionary with an entry referencing the dictionary itself), we are using the
RecursionError
to determine that the object is not "jsonable". This is far from been optimized. This PR updates the logic to return early as soon as a circular reference is detected.Code in this PR has been generated using VS Code + Inference Provider + gpt-oss-120b 😃
This PR should fix transient issues we have in the Windows CI: