🌐 [i18n-KO] Translated package_reference/mixins.md to Korean
#2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjfghk5697
reviewed
Apr 5, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fabxoe
commented
Apr 10, 2024
Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>
Co-authored-by: Seoyoung Kim <79852630+seoyoung-3060@users.noreply.github.com>
jungnerd
reviewed
Apr 18, 2024
| rendered properly in your Markdown viewer. | ||
| --> | ||
|
|
||
| # Mixins & serialization methods[[mixins--serialization-methods]] |
There was a problem hiding this comment.
@jungnerd
Fastai 는 Hub 처럼 그대로 두는 것도 좋아보이는데, Keras나 PyTorch 도 함께 번역을 해보자면.
패스트ai, 케라스, 파이토치 이렇게 되는데 이대로 가도 될까요?
Mixins과 Generic은 교재에서도 쓰이기에 '믹스인', '제네릭'으로 사용하면 될 것 같습니다.
그렇다면 영문과 한글이 혼용되게 되는데 의견 더 기다릴께요!
There was a problem hiding this comment.
다른 헤딩은 번역하지 않고 그대로 두는 게 좋아보입니다!
해당 헤딩은 문서 title에서는 번역을 하셨길래 제안드렸습니다 😊
fabxoe
commented
Apr 18, 2024
fabxoe
commented
Apr 18, 2024
fabxoe
commented
Apr 18, 2024
|
@Wauplin LGTM! This PR is good to go! Thanks in advance. |
Wauplin
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Translated the
package_reference/mixins.mdfile of the documentation to Korean.Thank you in advance for your review.
Part of #1626
Before reviewing
[[lowercased-header]])Who can review? (Initial)
Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@jungnerd, @heuristicwave May you please review this PR?