Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated guides/model_cards.md to Korean" #2128

Merged
merged 10 commits into from
Apr 5, 2024
Merged

🌐 [i18n-KO] Translated guides/model_cards.md to Korean" #2128

merged 10 commits into from
Apr 5, 2024

Conversation

SeungAhSon
Copy link
Contributor

@SeungAhSon SeungAhSon commented Mar 19, 2024 •
edited
Loading

What does this PR do?

Translated the guides/model_cards.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@SeungAhSon SeungAhSon changed the title 🌐 [i18n-KO] Translated guides/model cards.md to Korean" 🌐 [i18n-KO] Translated guides/model_cards.md to Korean" Mar 19, 2024
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

jungnerd
jungnerd reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 문서 번역 축하드립니다! 🎉
일부 리뷰를 해보았으니 확인 부탁드려요 :D

docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
SeungAhSon
SeungAhSon commented Mar 25, 2024
View reviewed changes
Copy link
Contributor Author

@SeungAhSon SeungAhSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor 추가했습니다!

docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
harheem
harheem reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승아님의 첫 번역을 축하드립니다 🤩🥳
앞으로의 번역 활동도 계속 응원하겠습니다 🥰

소소하게 몇 가지 코멘트를 남겨보았습니다. 잘 부탁드려요!

docs/source/ko/guides/model-cards.md Outdated

</Tip>

## 허브에서 모델 카드 불러오기
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 허브에서 모델 카드 불러오기
## Hub에서 모델 카드 불러오기

docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
docs/source/ko/guides/model-cards.md Outdated Show resolved Hide resolved
@SeungAhSon @jungnerd @harheem
fix: resolve suggestions
293d3c1 
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Harheem Kim <49297157+harheem@users.noreply.github.com>
@SeungAhSon SeungAhSon marked this pull request as ready for review March 28, 2024 12:27
@heuristicwave
Copy link
Contributor

@Wauplin I've reviewed this translation, please merge it.
I have a question, Is there a way to make sure my review commit is reflected in Live Preview?

@jungnerd
Copy link
Contributor

jungnerd commented Apr 5, 2024

@Wauplin I've reviewed this translation, please merge it. I have a question, Is there a way to make sure my review commit is reflected in Live Preview?

@Wauplin This PR is ready to merge!
By the way, @heuristicwave is Jihun Lim, co-leader of this team.🤗

@Wauplin
Copy link
Contributor

Wauplin commented Apr 5, 2024

Great! Thanks for the ping! :)
Sorry @heuristicwave I missed the ping 4 days ago but for sure I can merge! 🎉

Thanks @SeungAhSon @heuristicwave @jungnerd!

@Wauplin Wauplin merged commit ed3cc0b into huggingface:main Apr 5, 2024
@Wauplin
Copy link
Contributor

Wauplin commented Apr 5, 2024

I have a question, Is there a way to make sure my review commit is reflected in Live Preview?

Yes and no. The problem is that I need to click on "Approve and Run" to run the CI which makes the live preview active again. Otherwise the CI won't run. Problem is that I need to click on it after every commit to make the live preview up to date. Given the number of PRs and commits I kinda skipped it but if you want I can go back to it let's say once per day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harheem harheem harheem left review comments

@jungnerd jungnerd jungnerd left review comments

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeungAhSon @HuggingFaceDocBuilderDev @heuristicwave @jungnerd @Wauplin @harheem