Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing kwargs in PytorchHubMixin #2093

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 7, 2024

Fix breaking change introduced in #2058.

If __init__ expects a **kwargs parameter, we should pass the config to it. However if it expects something like **croco_kwargs, let's not forward it since config is most likely not expected by the underlying class that will receive the config.

This will fix integration like the dust3r one (see here + slack thread -private-).

cc @NielsRogge @not-lain

@Wauplin Wauplin requested a review from NielsRogge March 7, 2024 08:32
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin merged commit 381e941 into main Mar 7, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-passing-kwargs-in-pytorch-hub-mixin branch March 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants