Fix passing kwargs in PytorchHubMixin #2093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking change introduced in #2058.
If
__init__
expects a**kwargs
parameter, we should pass the config to it. However if it expects something like**croco_kwargs
, let's not forward it sinceconfig
is most likely not expected by the underlying class that will receive the config.This will fix integration like the dust3r one (see here + slack thread -private-).
cc @NielsRogge @not-lain