add tests

src/huggingface_hub/hf_api.py

@@ -4026,6 +4026,8 @@ def preupload_lfs_files(
                     f"Skipped upload for {len(new_lfs_additions) - len(new_lfs_additions_to_upload)} LFS file(s) "
                     "(ignored by gitignore file)."
                 )
+        else:
+            new_lfs_additions_to_upload = new_lfs_additions
 
         # Upload new LFS files
         _upload_lfs_files(

tests/test_hf_api.py

@@ -562,6 +562,39 @@ def _create_file(*parts) -> None:
             {".gitattributes", ".git_something/file.txt", "file.git", "temp", "nested/file.bin"},
         )
 
+    @use_tmp_repo()
+    def test_upload_folder_gitignore_already_exists(self, repo_url: RepoUrl) -> None:
+        # Ignore nested folder
+        self._api.upload_file(path_or_fileobj=b"nested/*\n", path_in_repo=".gitignore", repo_id=repo_url.repo_id)
+
+        # Upload folder
+        self._api.upload_folder(folder_path=self.tmp_dir, repo_id=repo_url.repo_id)
+
+        # Check nested file not uploaded
+        assert not self._api.file_exists(repo_url.repo_id, "nested/file.bin")
+
+    @use_tmp_repo()
+    def test_upload_folder_gitignore_in_commit(self, repo_url: RepoUrl) -> None:
+        # Create .gitignore file locally
+        (Path(self.tmp_dir) / ".gitignore").write_text("nested/*\n")
+
+        # Upload folder
+        self._api.upload_folder(folder_path=self.tmp_dir, repo_id=repo_url.repo_id)
+
+        # Check nested file not uploaded
+        assert not self._api.file_exists(repo_url.repo_id, "nested/file.bin")
+
+    @use_tmp_repo()
+    def test_upload_folder_ignore_gitignore(self, repo_url: RepoUrl) -> None:
+        # Create .gitignore file locally
+        (Path(self.tmp_dir) / ".gitignore").write_text("nested/*\n")
+
+        # Upload folder with `respect_gitignore=False`
+        self._api.upload_folder(folder_path=self.tmp_dir, repo_id=repo_url.repo_id, respect_gitignore=False)
+
+        # Check nested file is uploaded
+        assert self._api.file_exists(repo_url.repo_id, "nested/file.bin")
+
     def test_create_commit_create_pr(self):
         REPO_NAME = repo_name("create_commit_create_pr")
         self._api.create_repo(repo_id=REPO_NAME, exist_ok=False)