Force modelcards to use utf-8 encoding #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hfhv0.10.0 introduced modelcards that was previously hosted on a separate repo (https://github.com/nateraw/modelcards). When moving it intohuggingface_hub, the use of utf-8 encoding by default has been lost which cause some issues for windows users as highlighted by @BenjaminBossan in skops-dev/skops#162 (comment).This PR forces the use of
utf-8when loading/saving a repocard. Once that is merged, I will cherry-pick the commit inv0.10-releasebranch and bump the version tov0.10.1so that this inconsistency stays as little as possible in the wild :)@nateraw mind approving the PR ? 🙏
cc @adrinjalali