Add Spaces to Task Data #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merveenoyan
approved these changes
Dec 15, 2022
| @@ -58,6 +58,7 @@ const taskData: TaskDataCustom = { | |||
| id: "superb/hubert-large-superb-er", | |||
| }, | |||
| ], | |||
| spaces: [], | |||
There was a problem hiding this comment.
What are the keys for the dict in this list? description & id?
There was a problem hiding this comment.
it's an ExampleRepo same as the other repo types
osanseviero
approved these changes
Dec 16, 2022
|
maybe we could merge after the one on 🌜🛩 is merged 😅 |
|
Actually this one will need to be merged before https://github.com/huggingface/moon-landing/pull/4861, as the internal one depends on this |
julien-c
reviewed
Dec 20, 2022
|
Yes, Merve is curating a list of spaces, which is shared in Slack in the task pages channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for https://github.com/huggingface/moon-landing/pull/4861
This PR add a "spaces" attribute to the TaskData, used for displaying a Spaces section on the Task Page.
Note: I run the linted on the config files, so it may be better to check "Hide whitespace" in the "Files changed" tab :)