Snippet for sklearn

[merveenoyan]

Taking from #314 thought it would be better to have a separate branch instead of fork given I also change moon-landing code

[merveenoyan]

I somehow can't pass config to ModelInfo properly in Models.ts.

const x: SetOptional<ModelInfoWithSiblings, "siblings"> = new ModelInfo({
			_id:                 repo._id,
			id:                  repo.name,
			author:              repo.author,
			sha:                 commit.id,
			lastModified:        commit.author.date,
			lastAuthor:          { email: commit.author.email },
			private:             repo.config.private,
			gated:               repo.config.gated,
			discussionsDisabled: repo.config.discussionsDisabled,
			gitalyUid:           repo.gitalyUid,
			files,
			config,
		});
console.log({ x });
console.log({ config });

config is still { config: { filename: 'model.pkl' } } but in ModelInfo it's {}. Do you have any idea?

[osanseviero]

I'm not entirely sure to what does the code you're sharing correspond to. My workflow is to create a model repo with the same README.md and config.json as you would have in production, and within the sklearn method you can inspect the model by printing it.

You're doing

const skopsmodelFile = model.config.filename

But the model file should be within model.sklearn, as it's done for adapter_transformers and speechbrain. E.g. compare your internal code against

• https://github.com/huggingface/moon-landing/pull/4004/files#diff-70e0418cb1c6bf88268219ab03cc6b00d76364960e8ab99671c71bfeb8f78ff4R347-R352
• https://github.com/huggingface/moon-landing/pull/4004/files#diff-70e0418cb1c6bf88268219ab03cc6b00d76364960e8ab99671c71bfeb8f78ff4R359-R361

For debugging you can also add a console.log(config) in the internal PR to understand what's going on, but there you're fully overriding the config.

[osanseviero]

This looks good! Thanks for working on it! I left some minor suggestions and improvement requests

[osanseviero]

Let me know if it's ready for another review (and remember to mark as solved if things are resolved)

[merveenoyan]

@osanseviero WDYT

[osanseviero]

Looks good! I just left a suggestion on the comment 🔥 thanks!