-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize inference snippets
#106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snippets are good !
for the file path: currently we have Should it be:
|
I think it's ok to leave Wdyt ? |
Note: you can also easily do away with the regex stuff :)
Not saying this is better, I'll let you judge what's the best solution. |
Looks good ! I only found some admittedly petty comments to make. Still needs to try it live :) |
This PR:
Example screenshots of img-cls task (please check whether the snippets look correct: @Narsil @osanseviero ):
![Screenshot 2022-04-19 at 13 03 53](https://user-images.githubusercontent.com/11827707/163998062-da18bf52-0887-4488-b854-aa8f202ed6cf.png)
![Screenshot 2022-04-19 at 13 03 55](https://user-images.githubusercontent.com/11827707/163998056-f0cffe09-2265-480c-92ac-d8db479db455.png)
![Screenshot 2022-04-19 at 13 03 57](https://user-images.githubusercontent.com/11827707/163998048-81be22ad-4b27-4be9-82ac-3b2c6efda7d9.png)