fix EMAModel.use_ema_warmup#9812
Closed
chenguolin wants to merge 1 commit intohuggingface:mainfrom
chenguolin:patch-3
Closed
fix EMAModel.use_ema_warmup#9812chenguolin wants to merge 1 commit intohuggingface:mainfrom chenguolin:patch-3
EMAModel.use_ema_warmup#9812chenguolin wants to merge 1 commit intohuggingface:mainfrom
chenguolin:patch-3
Conversation
I do not understand for a long time why `use_ema_warmup` is forced to be `True` in `EMAModel.__init__()`.And it is also unreasonable to still use warmup by `cur_decay_value = (1 + step) / (10 + step)` when `use_ema_warmup=False`.
Member
|
I think this becomes a breaking change for folks using this class. It's better to deprecate the bevahiour. |
Contributor
Author
|
Maybe adding a deprecating logging? The current decay behavior is unreasonable for me:
|
Member
|
Deprecation is the way to go. We cannot introduce a breaking change like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I do not understand for a long time why
use_ema_warmupis forced to beTrueinEMAModel.__init__(). It is really inconvenient for really proferming fixed-decay EMA.And it is also unreasonable to still use warmup by
cur_decay_value = (1 + step) / (10 + step)whenuse_ema_warmup=False.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
General functionalities: @sayakpaul @yiyixuxu @DN6