Skip to content

Fix name when saving text inversion embeddings in dreambooth advanced scripts#8927

Merged
DN6 merged 1 commit intomainfrom
dreambooth-adv-fix
Jul 23, 2024
Merged

Fix name when saving text inversion embeddings in dreambooth advanced scripts#8927
DN6 merged 1 commit intomainfrom
dreambooth-adv-fix

Conversation

@DN6
Copy link
Copy Markdown
Collaborator

@DN6 DN6 commented Jul 22, 2024

What does this PR do?

Textual Inversion Embeddings were being saved using f"{output_dir}/{args.output_dir} which can give weird paths when using relative path names. Updating to use just the directory name with Path. e.g. f"{args.output_dir}/{Path(args.output_dir).name}

Fixes # (issue)
#8909

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from linoytsaban July 22, 2024 10:10
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban
Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants