-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[Core] Support single file from from_pretrained
#6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Closing this. Cc: @DN6 |
What does this PR do?
Fixes #6461.
@DN6, some considerations I kept in mind:
from_single_file
kwarg infrom_pretrained()
.from_single_file()
method and they know that they can either pass the local filepath or a URL. This workflow is quite well-known at this point in time.repo_id
andweight_name
like how it's done inload_lora_weights()
.load_lora_weights()
also supports passing a direct local path of the LoRA file, though.So, in a sense,
from_pretrained()
's behavior is not deviating fromfrom_single_file()
in terms of howfrom_pretrained()
is being called. WDYT?TODO
from_single_file()