-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[Tests] adds fast tests for single-file checkpoint loaders #6961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elif len(checkpoint) == 512: | ||
config_url = CONFIG_URLS["test_single_file_sd"] | ||
|
||
elif len(checkpoint) == 701: | ||
config_url = CONFIG_URLS["test_single_file_sdxl"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's any other sane way for us to verify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we add this into the test module? Why have it in src
if it's only relevant to tests? We can pass it in using Pipeline.from_single_file(original_config_file="<file url>")
. original_config_file
can be a URL now.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@DN6 I dug a bit deeper into this today and I think it's better NOT to add tests for this yet. This is because there's a reliance on
Both the above aspects heavily influence (and they should) how we craft our logic for single-file checkpoint loading. Since single-file checkpoints are quite heavily used in Do you agree to my reasoning? |
@sayakpaul That's cool with me. So the core issue is that the current We can put a brief pause on this while we figure out a more robust way to do the mappings. I can take a look into how to make |
Yes exactly. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Closing in favor of #7496. |
What does this PR do?
Fixes #6515.