Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaled_linear schedule in PNDM and DDPM #164

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

patil-suraj
Copy link
Contributor

This PR adds scaled_linear schedule in PNDM and DDPM schedulers so those could be used with latent/stable diffusion models.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, we should probably take these outside the inits later to avoid copying schedules 😅

@patil-suraj patil-suraj merged commit c1488ff into main Aug 11, 2022
@patil-suraj patil-suraj deleted the scaled-linear branch August 11, 2022 09:26
@damian0815
Copy link
Contributor

hi, sorry to dig up an old issue. i'm hacking around on Everydream (a dreambooth-like finetuner for Stable Diffusion). i'm noticing substantial differences in outputs depending on whether the beta_scheduler is left at scaled_linear (loaded from the SD2.1 diffusers-format checkpoint) or overridden to linear. in particular, training with scaled_linear makes changes in learning rate have more wildly unpredictable effects on training losses than when it's overridden with linear. i'm not sure how to find out which is more "correct" - would greatly appreciate any thoughts you might have.

@patrickvonplaten
Copy link
Contributor

cc @patil-suraj and @pcuenca herer maybe?

@damian0815
Copy link
Contributor

damian0815 commented Feb 15, 2023

ahh, nm, it doesn't seem to make that much difference, i was being confused by another hyperparameter i didn't notice was changing. sorry for the noise!

PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
Rewrite&Move tflite examples to up tank dir
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants