Deprecate upcast_vae in SDXL based pipelines
#12619
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed the type cast in the AutoencoderKL Decoder in this PR in order to address graph breaks. The PR breaks some Mellon Nodes and default SDXL inference. The problem is that the casting is used to address an issue in the base SDXL VAE, which overflows when running in FP16.
The overflow issue has been fixed for a while and almost all finetunes use the fixed VAE, so this logic that conditionally upcasts the upsample layers of the VAE is no longer needed. The memory savings from this selective layer casting in also quite minimal, so we can safely upcast all layers in the VAE if needed.
This PR
upcast_vaemethod in the SDXL based pipelines that selectively upcasts only the upsample layers of the decoder in favour of upcasting the entire VAE if upcasting is required.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.