Skip to content

Conversation

J4BEZ
Copy link
Contributor

@J4BEZ J4BEZ commented Sep 2, 2025

What does this PR do?

This PR enables WanVACETransformer3DModel to use methods from AttentionMixin, such as set_attn_processor().
#12186

I would like to express my sincere gratitude to the Hugging Face team for your continuous efforts, which make it easier and faster for researchers and developers to enjoy deep learning every day.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

At your convenience, I would be grateful if you could review this, @DN6

to enable methods like `set_attn_processor()`.
Copy link
Contributor

@tolgacangoz tolgacangoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @J4BEZ, thanks for adding this. Also importing it?

@J4BEZ
Copy link
Contributor Author

J4BEZ commented Sep 3, 2025

@tolgacangoz Yes, absolutely! Importing AttentionMixin is essential.
I sincerely appreciate you catching this — it was a close call.

Wishing you a peaceful day and good health.

@J4BEZ J4BEZ requested a review from tolgacangoz September 3, 2025 01:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@tolgacangoz tolgacangoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think it seems OK now.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DN6 DN6 merged commit 6682956 into huggingface:main Sep 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants