[lora_conversion] Enhance key handling for OneTrainer components in LORA conversion utility (#11441)#11487
Merged
sayakpaul merged 2 commits intohuggingface:mainfrom May 6, 2025
Conversation
sayakpaul
reviewed
May 5, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
May 5, 2025
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Amazing, thanks! I just ran the integration LoRA tests for Flux and they all pass.
…ORA conversion utility (huggingface#11441)
iamwavecut
force-pushed
the
fix-onetrainer-lora-conversion
branch
from
41d6fad to
717d6e4
Compare
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Contributor
Author
|
@sayakpaul thanks, for the suggestion, committed. Also rebased on a |
Member
|
Amazing, thank you! Will merge once the CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11441
I tried to keep changeset somehow minimal, while doing it the same way as it's already done.
Before submitting
_convert_mixture_state_dict_to_diffusers#11441Who can review?
@sayakpaul would be the most relevant I suppose.