[test_models_transformer_hunyuan_video] help us test torch.compile() for impactful models#11431
Merged
sayakpaul merged 4 commits intohuggingface:mainfrom Apr 30, 2025
Merged
Conversation
sayakpaul
reviewed
Apr 28, 2025
Member
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks for the PR! I just ran the tests but ran into errors: https://pastebin.com/A6c4gnwd.
@a-r-r-o-w possible to take a look when you have a moment?
Comment on lines
93
to
95
| def test_gradient_checkpointing_is_applied(self): | ||
| expected_set = {"HunyuanVideoTransformer3DModel"} | ||
| super().test_gradient_checkpointing_is_applied(expected_set=expected_set) |
Member
There was a problem hiding this comment.
This can be done in a separate PR.
Contributor
|
Yeah, our Hunyuan implementation is not compatible with |
Member
|
Reopening as this PR has the test case. |
Member
|
I have run the tests and they also pass: export RUN_SLOW=1
export RUN_COMPILE=1
pytest tests/models/transformers/test_models_transformer_hunyuan_video.py -k "test_torch_compile_recompilation_and_graph_break" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11430
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.