Fixed requests.get function call by adding timeout parameter.#11156
Merged
hlky merged 8 commits intohuggingface:mainfrom Apr 4, 2025
Merged
Fixed requests.get function call by adding timeout parameter.#11156hlky merged 8 commits intohuggingface:mainfrom
hlky merged 8 commits intohuggingface:mainfrom
Conversation
DN6
reviewed
Mar 28, 2025
Contributor
Author
|
@DN6, I've made the requested changes. |
Contributor
|
@bot /style |
Contributor
|
Style fixes have been applied. View the workflow run here. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
Failing test doesn't appear to have anything to do with these changes. |
Contributor
Author
|
@yiyixuxu is this PR just waiting on review or is the action with me at the moment? |
Contributor
|
Failing tests are unrelated. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed requests.get() function call by adding configurable env variable timeout (default is 60 seconds).
Co-authored with @Sai-Suraj-27.
Fixes #7730
FYI: @DN6 and @asomoza
Before submitting
requests.get()function call by addingtimeoutparameter #7742)documentation guidelines, and
here are tips on formatting docstrings.