Skip to content

use style bot GH Action from huggingface_hub #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

hanouticelina
Copy link
Collaborator

What does this PR do?

This PR updates the style bot workflow to use the newly added GH action in huggingface_hub in huggingface/huggingface_hub#2898. I tested the workflow in a diffusers fork here: https://github.com/hanouticelina/diffusers/pull/2 and it works as expected :)

cc @Wauplin for viz

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for shipping it!

@sayakpaul sayakpaul requested review from DN6 and hlky March 5, 2025 08:11
Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DN6 DN6 merged commit fbf6b85 into main Mar 5, 2025
10 of 11 checks passed
@hanouticelina
Copy link
Collaborator Author

It's okay (security-wise) if this PR is merged even though we have some improvements to add in the GH action (cf the private slack discussion here), since in the case of diffusers, we check that the Makefile and setup.py files are not updated before running the style command. I will open a follow-up PR as soon as we add the improvements!

@sayakpaul sayakpaul deleted the use-style-bot-from-hfh branch March 6, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants